Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(color): EXIT key handling #2658

Merged
merged 1 commit into from
Oct 31, 2022
Merged

fix(color): EXIT key handling #2658

merged 1 commit into from
Oct 31, 2022

Conversation

raphaelcoeffic
Copy link
Member

This PR fixes an issue introduced in #2573.

What happens is the following:

  • KEY_EXIT is pressed and released (EVT_KEY_BREAK(KEY_EXIT))
  • this gets translated into [LV_KEY_ESC / LV_INDEV_STATE_PRESSED]
  • now, as the matching was wrong (KEY_EXIT instead of LV_KEY_ESC), the state would never become LV_INDEV_STATE_RELEASED again.
  • any none LVGL key (anything apart from ENTER and EXIT) would then trigger a double CANCEL.

@raphaelcoeffic
fix(color): EXIT key handling
c704c81 
This issue has been introduced in #2573.
@raphaelcoeffic raphaelcoeffic added this to the 2.8 milestone Oct 31, 2022
@raphaelcoeffic raphaelcoeffic mentioned this pull request Oct 31, 2022
Merged
@pfeerick pfeerick added color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour bug/regression ↩️ A new version of EdgeTX broke something labels Oct 31, 2022
@pfeerick pfeerick merged commit 370aff6 into main Oct 31, 2022
@pfeerick pfeerick deleted the fix-key-exit branch October 31, 2022 10:41
@raphaelcoeffic raphaelcoeffic mentioned this pull request Nov 1, 2022
Closed
1 task
pfeerick pushed a commit that referenced this pull request Nov 2, 2022
@raphaelcoeffic @pfeerick
fix(color): EXIT key handling (#2658)
b5f8a75 
This issue has been introduced in #2573.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug/regression ↩️ A new version of EdgeTX broke something color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raphaelcoeffic @pfeerick