Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hebrew audio pack - selection support #3511

Merged

Conversation

offer-shmuely
Copy link
Contributor

add support for Hebrew audio selection

image

@offer-shmuely offer-shmuely changed the title add support for Hebrew audio selection Hebrew audio pack - selection support Apr 22, 2023
@offer-shmuely
Copy link
Contributor Author

offer-shmuely commented May 6, 2023

Will it make to 2.9?
Theoretically there is no risk here.

@pfeerick pfeerick added enhancement ✨ New feature or request translation labels May 11, 2023
@pfeerick pfeerick added this to the 2.9 milestone May 11, 2023
@pfeerick
Copy link
Member

Yup, looks fine. We've all just been snowed under with real-life stuff 😢

I can't comment on/validate the tts_he.cpp part other than "look good"- that is something native speakers will need to comment on as this gets some use - if any language semantics/characteristics aren't handled properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants