feat(radio): Allow precision for mix slow up/dn to be set to 10ms or 100ms. #4612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
I would like to add some gtest, but can do as a separate PR |
philmoz
force-pushed
the
mix-slow-prec
branch
from
3e0f0e9
to
164127a
Compare
|
I've duplicated the existing tests and modified them to use the 10ms precision. |
|
LGTM on X9D+, MT12 and TX16S. I'm still a little unsure if showing it as |
13 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4593
Support the range for slow up/down on a mix line to be 0-2.5s in 10ms increments.