File encoding and CRLFs #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcezard
suggested changes
Jun 23, 2017
pyclarity_lims/lims.py
Outdated
| @@ -100,7 +100,11 @@ def get_file_contents(self, id=None, uri=None): | |||
| url = urljoin(self.baseuri, '/'.join(segments)) | |||
There was a problem hiding this comment.
I know it is not something you wrote but can you change this urljoin to self.get_uri?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
requestsresponse object'stextproperty is called,self.encodingis applied toself.content. Usually this isNoneand falls back toself.apparent_encoding.In a case we were seeing though, a UTF-16-encoded XML file from a Windows machine was breaking this: since the
Content-Typeresponse header contained the stringtext, ISO-8859-1 encoding was being applied (see http://docs.python-requests.org/en/latest/user/advanced/?highlight=encoding#encodings).Closes #10 by adding optional encodings and ability to convert CRLFs to
\n.