Parse pools in a Step as dict #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix a few bug associated with the editing of dictionaries
1 similar comment
tcezard
commented
Nov 19, 2017
| @@ -292,6 +292,8 @@ def _setitem(self, key, value): | |||
| self._elems[0].attrib[key] = value | |||
|
|
|||
| def _delitem(self, key): | |||
| if key in ['artifact', 'step', 'rework-step']: | |||
| key = key + '-uri' | |||
There was a problem hiding this comment.
Deleting any of ['artifact', 'step', 'rework-step'] 's key would have resulted in KeyError
tcezard
commented
Nov 19, 2017
| elem1 = node | ||
| break | ||
| if elem1: | ||
| self.rootnode(self.instance).remove(elem1) |
There was a problem hiding this comment.
Creating a placement was working however overwriting was resulting in a new placement being created and the old one left intact
pyclarity_lims/descriptors.py
Outdated
| node = ElementTree.SubElement(self.rootnode(self.instance), 'pool') | ||
| node.attrib['name'] = key | ||
| node.attrib['uri'] = pool.uri | ||
| for input in list_input: |
There was a problem hiding this comment.
Should perhaps not be an already defined Python function (input)
mwhamgenomics
requested changes
Dec 18, 2017
pyclarity_lims/descriptors.py
Outdated
| node = ElementTree.SubElement(self.rootnode(self.instance), 'pool') | ||
| node.attrib['name'] = key | ||
| node.attrib['uri'] = pool.uri | ||
| for input in list_input: |
There was a problem hiding this comment.
Shadows builtin name input
| break | ||
|
|
||
| def _parse_element(self, element, **kwargs): | ||
| from pyclarity_lims.entities import Artifact |
There was a problem hiding this comment.
Does Artifact take long enough to import that we need to lazy-load it?
There was a problem hiding this comment.
This is not about lazy loading but is meant to avoid import cyclic dependencies.
Fix documentation
mwhamgenomics
approved these changes
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add XmlPooledInputDict that parses the pools from a Step
Also fix a few bug associated with the editing of dictionaries