Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check how measure numbers in annot tool tips are retrieved, there seems to be something wrong… #281

Closed
nikobeer opened this issue Sep 23, 2022 · 12 comments · Fixed by #380

Comments

@nikobeer
Copy link
Member

Bildschirmfoto 2022-09-23 um 18 04 14

@nikobeer
Copy link
Member Author

nikobeer commented Sep 23, 2022

Attribute "n", "label" or what…?

@bwbohl
Copy link
Member

bwbohl commented Oct 5, 2022

could you please describe what you were expecting in the above example, both visually and in terms of encoding, and maybe provide encoding examples?

@bwbohl
Copy link
Member

bwbohl commented Oct 5, 2022

As you self-assigned: will you fix this by yourself or do you need some help?

@bwbohl bwbohl added this to the annotations milestone Oct 5, 2022
@nikobeer
Copy link
Member Author

nikobeer commented Oct 5, 2022

Yes, I will fix it – at the end of October/beginning November. There is probably a special xquery for these tooltips that is not aware of some "logic modifications" we made to the full Annotation View xquery in the past.

@bwbohl bwbohl modified the milestones: annotations, 1.0.0-beta.5 Nov 2, 2022
@nikobeer
Copy link
Member Author

nikobeer commented Nov 23, 2022

Beginning at getAnnotations.xql…

@roewenstrunk
Copy link
Member

The problem is not supported @Label in line

then(if ($lang = 'de') then (concat('Takt ',$elem/@n)) else (concat('Bar ',$elem/@n)))

@riedde riedde modified the milestones: 1.0.0-beta.5, annotations Dec 20, 2022
@krHERO
Copy link
Member

krHERO commented May 30, 2024

@nikobeer what is the status of this issue?

@nikobeer
Copy link
Member Author

nikobeer commented Jun 4, 2024

This problem is not solved yet.

nikobeer added a commit to Max-Reger-Institut/Edirom-Online that referenced this issue Jun 4, 2024
nikobeer added a commit that referenced this issue Jun 4, 2024
@nikobeer
Copy link
Member Author

nikobeer commented Jun 4, 2024

Fixed. @bwbohl please close when pulled…

@bwbohl
Copy link
Member

bwbohl commented Jun 4, 2024

am I right to assume that the to above commits in the MRI Edirom Online are the fix for this issue?

@nikobeer
Copy link
Member Author

nikobeer commented Jun 4, 2024

The first (fe4ed58) is in the MRI's repo. It is only valid for the RWA Edirom as getAnnotation.xql there looks completely different from the original Edirom file. The second (a55a0f5) is the actual fix for Edirom (same code change). See #380.

@bwbohl bwbohl linked a pull request Jun 4, 2024 that will close this issue
@bwbohl
Copy link
Member

bwbohl commented Jun 4, 2024

thx for clarifying, oversay the corresponding PR. I now linked the issue and the PR from the Development section in the righthand siedebar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants