Skip to content
This repository has been archived by the owner on Jan 12, 2020. It is now read-only.

[Feature] Support for OAuth #18

Closed
3 tasks done
EdricChan03 opened this issue Aug 29, 2018 · 0 comments
Closed
3 tasks done

[Feature] Support for OAuth #18

EdricChan03 opened this issue Aug 29, 2018 · 0 comments
Assignees
Labels
help wanted Issues/ PRs that will benefit help from the community. priority: important Issues/PRs that is important to resolve ASAP.

Comments

@EdricChan03
Copy link
Owner

EdricChan03 commented Aug 29, 2018

There's currently no support for certain API options as of now due to a lack of OAuth capabilities.

TODO

  • Decide on whether to leave this up to the consumer EDIT: This has to be left up to the consumer as the OAuth screen cannot be used with CORS
  • Read up docs on how to implement OAuth
  • Read up on how to use HttpClient with OAuth EDIT: Use the Authorization: Bearer HTTP header or the access_token parameter

Progress

5/10/18

I've added basic OAuth 2.0 support to the demo app, although I haven't committed the changes yet.

6/10/18

I'm planning to try to get this in by today.

New changes

There'll be several new parameters as part of OAuth to be implemented in NgxYtdApiGenericProperties:

Property Description
accessToken The access token returned from a successful authentication via Google's OAuth
@EdricChan03 EdricChan03 created this issue from a note in 1.0.0-alpha.* (To do) Aug 29, 2018
@EdricChan03 EdricChan03 self-assigned this Aug 29, 2018
@EdricChan03 EdricChan03 added in progress Issues/PRs that are in progress. help wanted Issues/ PRs that will benefit help from the community. priority: important Issues/PRs that is important to resolve ASAP. labels Aug 29, 2018
@EdricChan03 EdricChan03 changed the title Add support for OAuth [Feature] Support for OAuth Aug 29, 2018
@EdricChan03 EdricChan03 added the resolution: delayed Issues/PRs will be delayed until further notice. label Sep 2, 2018
@EdricChan03 EdricChan03 removed the resolution: delayed Issues/PRs will be delayed until further notice. label Oct 5, 2018
1.0.0-alpha.* automation moved this from To do to Done Oct 6, 2018
@EdricChan03 EdricChan03 removed the in progress Issues/PRs that are in progress. label Oct 6, 2018
EdricChan03 added a commit that referenced this issue Oct 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Issues/ PRs that will benefit help from the community. priority: important Issues/PRs that is important to resolve ASAP.
Projects
1.0.0-alpha.*
  
Done
Development

No branches or pull requests

1 participant