Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove decision tree and random forest learners from requires_dense set #207

Closed
dan-blanchard opened this issue Nov 21, 2014 · 2 comments
Closed

Remove decision tree and random forest learners from requires_dense set #207

dan-blanchard opened this issue Nov 21, 2014 · 2 comments
Labels
enhancement sklearn-compatibility
Milestone
1.1

Comments

@dan-blanchard
Copy link
Contributor

Whenever the next version of scikit-learn comes out, it will support sparse input for decision trees and random forests, which is pretty great news. This was added in scikit-learn/scikit-learn#3173.

Anyway, we'll need to update our skll.learner._REQUIRES_DENSE set to remove those learners from it to take advantage of this.
@dan-blanchard dan-blanchard added this to the 1.1 milestone Nov 21, 2014
@dan-blanchard dan-blanchard removed this from the 1.1 milestone Dec 10, 2014
@dan-blanchard
Copy link
Contributor Author

0.16 is out with this, so we should do it.

@dan-blanchard dan-blanchard added this to the 1.1 milestone Apr 6, 2015
@desilinguist desilinguist mentioned this issue Jul 14, 2015
Merged
@desilinguist
Copy link
Member

Addressed by #245.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement sklearn-compatibility
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
2 participants
@desilinguist @dan-blanchard