-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several minor bugfixes #245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correctly interpret the `base_estimator` fixed parameter for AdaBoostClassifiers and AdaBoostRegressors as objects instead of strings (#238). - Add corresponding unit tests for both classification and regression. - Update documentation.
- Addresses #234.
- We are already passing in seeds in `model_kwargs` for all classifiers/regressors so we don't need to set the numpy global random seed. - Include `Lasso`, `ElasticNet`, and `LinearSVR` when setting `random_state` in `model_kwargs`. - Update AdaBoost classification test expected value that is affected by this change.
- Make sure that the base estimator for Adaboost has a fixed seed so that results are replicable. - Update test expected value again.
- In the new version of scikit-learn, only `GradientBoostingClassifier` and `GradientBoostingRegressor` seem to require dense input. - Move `make_sparse_data()` to `utils.py` - Update `test_sparse_predict()` to include all sparse-friendly classifiers. - Update any other tests' expected values.
👍 I looked at this on my phone at lunch and forgot to comment. Looks good to me. |
Looks good to me too, thanks! |
desilinguist
added a commit
that referenced
this pull request
Jul 14, 2015
…l-minor-bugfixes Several minor bugfixes
This was referenced Jul 14, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base_estimator
fixed parameter for AdaBoostClassifiers and AdaBoostRegressors as objects instead of strings.hasher_features
typo inexperiments.py
(Bug when checking ifhasher_features
is a valid option #234).random_state
seeds inmodel_kwargs
for all classifiers/regressors so we don't need to set thenumpy
global random seed.Lasso
,ElasticNet
,LinearSVR
, andSVC
when setting the above seeds inmodel_kwargs
.GradientBoostingClassifier
andGradientBoostingRegressor
require dense input.make_sparse_data()
toutils.py
test_sparse_predict()
to include all sparse-friendly classifiers.