Fix learning curve gridmap bug and tweak y-limit computation. #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For the learning curve, task the return value was not a list of dictionaries as it should be.
desilinguist
requested review from
aoifecahill,
mulhod,
Lguyogiro and
jbiggsets
|
This PR is ready for review. You can click on the last green check mark in the commit history to see that the tests all passed and that the coverage is the same. |
jbiggsets
approved these changes
Nov 13, 2017
aoifecahill
approved these changes
Nov 13, 2017
This was referenced Nov 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very short PR.
_classify_featureset()such that running a learning curve task viagridmapactually works (see issue Bug in SKLL when generating learning curves via gridmap #386).