Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve y-limits for learning curves #389

Closed
desilinguist opened this issue Nov 10, 2017 · 2 comments
Closed

Improve y-limits for learning curves #389

desilinguist opened this issue Nov 10, 2017 · 2 comments
Assignees
Milestone

Comments

@desilinguist
Copy link
Member

desilinguist commented Nov 10, 2017

If we have learning curves for which the scores are very close to the maximum for the given metric (see attached example below), the curves have limits that theoretically may not make sense. It's not a big issue but perhaps we can fix it although we already have some intelligent computation of y-limits in SKLL that should be handling this.

titanic_learning_curve_all

@desilinguist
Copy link
Member Author

I think I see what's going on. The y-limit computation function uses the following statement:

upper_limit = 1.1 if max_score <= 1 else math.ceil(max_score)

where max_score is computed as the sum of the mean plus the standard deviation.

In the above example, the mean is 0.996401028277635 and the std. dev. is 0.011380947877212683 and the sum is 1.0077819761548477 for which the ceiling is 2 and hence the weird limits. We should be able to fix this.

@desilinguist
Copy link
Member Author

Addressed by #390.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant