add db.name span attribute to mysql & pg (#2622)

Effect-TS · Apr 26, 2024 · e7d1607 · e7d1607
1 parent f363af0
commit e7d1607
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/packages/sql-mysql2/src/Client.ts b/packages/sql-mysql2/src/Client.ts
@@ -166,16 +166,22 @@ export const make = (
       (conn) => new ConnectionImpl(conn)
     )
 
+    const spanAttributes: Array<[string, unknown]> = [
+      ["db.system", "mysql"],
+      ["server.address", options.host ?? "localhost"],
+      ["server.port", options.port ?? 3306]
+    ]
+
+    if (options.database) {
+      spanAttributes.push(["db.name", options.database])
+    }
+
     return Object.assign(
       Client.make({
         acquirer: Effect.succeed(poolConnection),
         transactionAcquirer,
         compiler,
-        spanAttributes: [
-          ["db.system", "mysql"],
-          ["server.address", options.host ?? "localhost"],
-          ["server.port", options.port ?? 3306]
-        ]
+        spanAttributes
       }),
       { config: options }
     )

diff --git a/packages/sql-pg/src/Client.ts b/packages/sql-pg/src/Client.ts
@@ -185,6 +185,7 @@ export const make = (
         compiler,
         spanAttributes: [
           ["db.system", "postgresql"],
+          ["db.name", opts.database ?? options.username ?? "postgres"],
           ["server.address", opts.host ?? "localhost"],
           ["server.port", opts.port ?? 5432]
         ]