Skip to content

Commit

Permalink
Rollback previous commit, misread the conclusion in PR stride3d#1868
Browse files Browse the repository at this point in the history
  • Loading branch information
Eideren committed Oct 2, 2023
1 parent e2dce13 commit 6d54e1a
Showing 1 changed file with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -320,10 +320,8 @@ protected virtual bool PrepareMember(MemberDescriptorBase member, MemberInfo met
member.Mode = memberAttribute.Mode;
if (!member.HasSet)
{
if (memberAttribute.Mode == DataMemberMode.Assign)
throw new ArgumentException($"{memberType.FullName} {member.OriginalName} is not writeable by {memberAttribute.Mode.ToString()}, its {nameof(DataMemberMode)} must not be {memberAttribute.Mode}.");
if (memberType.IsValueType || memberType == typeof(string))
throw new ArgumentException($"{memberType.FullName} {member.OriginalName} is not writeable by {memberAttribute.Mode.ToString()}, {member.OriginalName} must have a setter.");
if (memberAttribute.Mode == DataMemberMode.Assign || memberType.IsValueType || memberType == typeof(string))
member.Mode = DataMemberMode.Never;
}
member.Order = memberAttribute.Order;
}
Expand Down

0 comments on commit 6d54e1a

Please sign in to comment.