Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readonly serializing on structs/string #1868

Closed
wants to merge 1 commit into from

Conversation

IXLLEGACYIXL
Copy link
Collaborator

PR Details

Fixes Serialization of readonly members

Description

  1. readonly structs/strings dont get serialized anymore
  2. get only properties of structs/strings dont get serialized anymore
  3. HasSet fix in fielddescriptor

Related Issue

https://discord.com/channels/500285081265635328/1156630820430303373
First part of fixing the serialization on get only members.
Fixing non backing fields is unaffected by this PR

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed. ( The Image tests and rasterized fonts test fail i was never able to get them working, but they fail without the changes too )

@Eideren
Copy link
Collaborator

Eideren commented Oct 8, 2023

Can I close this one @IXLLEGACYIXL ?

@IXLLEGACYIXL
Copy link
Collaborator Author

yes

@IXLLEGACYIXL IXLLEGACYIXL deleted the SerializerProblems branch October 18, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants