Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom named climate type's. #1

Closed
brianGit78 opened this issue Oct 19, 2018 · 5 comments
Closed

Add support for custom named climate type's. #1

brianGit78 opened this issue Oct 19, 2018 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@brianGit78
Copy link

I get the following error when I run the Ecobee Node Server for about 24 hours:

2018-10-16 07:01:53,638 DEBUG Update detected in thermostat Main Floor(511866920242) doing full update.
2018-10-16 07:01:53,640 DEBUG Tokens valid until: 2018-10-16T07:37:52
2018-10-16 07:01:53,641 INFO Getting Full Thermostat Data for 511866920242
2018-10-16 07:01:54,049 ERROR Exception in thread Thread-2:
Traceback (most recent call last):
File "/usr/lib/python3.5/threading.py", line 914, in _bootstrap_inner
self.run()
File "/usr/lib/python3.5/threading.py", line 862, in run
self._target(*self._args, **self._kwargs)
File "/home/pi/.local/lib/python3.5/site-packages/polyinterface/polyinterface.py", line 738, in _parseInput
self.longPoll()
File "./ecobee-poly.py", line 176, in longPoll
self.updateThermostats()
File "./ecobee-poly.py", line 189, in updateThermostats
self.nodes[thermostatId].update(thermostat, fullData)
File "/home/pi/.polyglot/nodeservers/Ecobee/node_types.py", line 207, in update
'GV3': climateMap[self.program['currentClimateRef']],
KeyError: 'wakeup'

@jimboca jimboca self-assigned this Dec 11, 2018
@jimboca jimboca added the bug Something isn't working label Dec 11, 2018
@jimboca jimboca added this to the 2.0.7 milestone Dec 11, 2018
@jimboca
Copy link
Collaborator

jimboca commented Dec 11, 2018

I see the issue here, the nodeserver only understands these:

climateMap = {
  'away': 0,
  'home': 1,
  'sleep': 2,
  'smart1': 3,
  'smart2': 4,
  'smart3': 5,
  'smart4': 6,
  'smart5': 7,
  'smart6': 8,
  'smart7': 9,
  'unknown': 10
}

and you have named one 'wakeup'. Will need to figure out how to support custom named climate modes. This will require the profile be custom generated for each person.

@jimboca jimboca modified the milestones: 2.0.7, 2.0.8 Dec 11, 2018
@jimboca
Copy link
Collaborator

jimboca commented Dec 11, 2018

This will be more effort so pushed out to after the next release. If you change the name from wakeup back to smart1 then it will no longer crash. :)

@jimboca
Copy link
Collaborator

jimboca commented Dec 13, 2018

The code is fixed to not crash, it will not proper climate type in the ISY Admin Console, but everything else should work.
Will work on supporting custom names soon.

@jimboca jimboca changed the title v2.0.5 KeyError: 'wakeup' after about 24 hours of operation Add support for custom named climate type's. Dec 27, 2018
jimboca added a commit that referenced this issue Dec 29, 2018
jimboca added a commit that referenced this issue Dec 29, 2018
jimboca added a commit that referenced this issue Dec 29, 2018
jimboca added a commit that referenced this issue Dec 29, 2018
jimboca added a commit that referenced this issue Dec 29, 2018
@jimboca
Copy link
Collaborator

jimboca commented Dec 29, 2018

This should all be fixed now, please let me know if it's working for you and I will close.

@jimboca
Copy link
Collaborator

jimboca commented Dec 31, 2018

All working in 2.0.17

@jimboca jimboca closed this as completed Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants