amphp#64 some progress

Ekstazi · Dec 11, 2018 · 0e060da · 0e060da
1 parent 866fbf4
commit 0e060da
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 9 deletions.
diff --git a/lib/Context/Thread.php b/lib/Context/Thread.php
@@ -193,7 +193,6 @@ public function kill()
             } finally {
                 $this->close();
             }
-            $this->oid = 0;
         }
     }
 
@@ -249,7 +248,7 @@ public function join(): Promise
                 Loop::disable($this->watcher);
                 $this->close();
             }
-            $this->oid = 0;
+
             return $response->getResult();
         });
     }

diff --git a/lib/Worker/TaskWorker.php b/lib/Worker/TaskWorker.php
@@ -155,11 +155,13 @@ public function restart($force = false): Promise
     {
         return call(function () use ($force) {
             if ($force) {
-                $this->context->kill();
+                $this->kill();
             } else {
                 yield $this->shutdown();
             }
-            yield $this->context->start();
+
+			$context = yield $this->context->restart($force);
+			return new static($context);
         });
     }
 }
diff --git a/lib/Worker/Worker.php b/lib/Worker/Worker.php
@@ -45,7 +45,7 @@ public function kill();
     /**
      * Restart worker.
      * @param bool $force Whether for cancel current task or wait it finished
-     * @return Promise
+     * @return Promise<Worker> New created  worker
      */
     public function restart($force = false): Promise;
 }
diff --git a/test/Worker/AbstractWorkerTest.php b/test/Worker/AbstractWorkerTest.php
@@ -267,25 +267,27 @@ public function run(Environment $environment)
     public function testRestart()
     {
         Loop::run(function () {
-            $worker = $this->createWorker();
+            $worker = $original = $this->createWorker();
             for ($i=0; $i<=1; $i++) {
                 $returnValue = yield $worker->enqueue(new TestTask(42));
                 $this->assertEquals(42, $returnValue);
 
-                yield $worker->restart();
+                $worker = yield $worker->restart();
+                $this->assertNotEquals($worker, $original);
             }
         });
     }
 
     public function testForceRestart()
     {
         Loop::run(function () {
-            $worker = $this->createWorker();
+            $worker = $original = $this->createWorker();
             for ($i=0; $i<=1; $i++) {
                 $returnValue = yield $worker->enqueue(new TestTask(42));
                 $this->assertEquals(42, $returnValue);
 
-                yield $worker->restart(true);
+                $worker = yield $worker->restart(true);
+				$this->assertNotEquals($worker, $original);
             }
         });
     }