Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all compiler warnings #186

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

jballoffet
Copy link
Member

@jballoffet jballoffet commented Dec 3, 2023

🎉 New feature

Related: #87

Summary

This PR modifies the PlatformIO project to enable all compiler warnings by setting the -Wall and -Wextra flags.

More information regarding PlatformIO build flags can be found here: https://docs.platformio.org/en/latest/projectconf/sections/env/options/build/build_flags.html.

More PRs will be sent to keep improving the code structure.

Test it

Tested by compiling the source code.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Javier Balloffet <javier.balloffet@gmail.com>
@jballoffet jballoffet mentioned this pull request Dec 3, 2023
6 tasks
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jballoffet
Copy link
Member Author

LGTM!

Thanks!

@jballoffet jballoffet merged commit dc3a0ad into humble Dec 4, 2023
2 of 3 checks passed
@jballoffet jballoffet deleted the jballoffet/enable-warnings branch December 4, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants