Add command methods #187
Merged
Add command methods #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francocipollone
requested changes
Dec 4, 2023
|
BTW, is the |
jballoffet
force-pushed
the
jballoffet/add-command-methods
branch
from
635356f
to
e1c4493
Compare
Signed-off-by: Javier Balloffet <javier.balloffet@gmail.com>
Signed-off-by: Javier Balloffet <javier.balloffet@gmail.com>
jballoffet
force-pushed
the
jballoffet/add-command-methods
branch
from
e1c4493
to
ceaa3c0
Compare
Yes, I will fix it in a subsequent PR so as to ease the review process. Thanks for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Related: #87
Summary
This PR adds callback methods for each CLI command as a stepping stone towards decoupling the main application logic from the shell and CLI business logic. It also removes some commands that may result in HW damage if wrongly used.
More PRs will be sent to keep improving the code structure.
Note: this PR is expected to be submitted after #186.
Test it
Tested by performing manual integration tests on the robot hardware.
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.