Fix params passing #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also, weights now get dumped regardless of whether a holdout set is passed
- also implemented load_params - got rid of duplicate load_embedding func
ericmjl
requested changes
Apr 27, 2020
Co-Authored-By: Eric Ma <ericmjl@users.noreply.github.com>
Co-Authored-By: Eric Ma <ericmjl@users.noreply.github.com>
Co-Authored-By: Eric Ma <ericmjl@users.noreply.github.com>
Co-Authored-By: Eric Ma <ericmjl@users.noreply.github.com>
Co-Authored-By: Eric Ma <ericmjl@users.noreply.github.com>
ericmjl
reviewed
Apr 27, 2020
ericmjl
approved these changes
Apr 27, 2020
|
MERGING! |
ElArkk
added a commit
that referenced
this pull request
Oct 14, 2021
* switched to load_params function - also, weights now get dumped regardless of whether a holdout set is passed * dump params also dumps dense weights - also implemented load_params - got rid of duplicate load_embedding func * Updated info on evotuning * Update docstrings, make steps_per_print truly optional * formatting * make format * remove unused imports * small prose changes * change back step_per_print default * remove code duplication * remove commented out code * Update README.md Co-Authored-By: Eric Ma <ericmjl@users.noreply.github.com> * Update README.md Co-Authored-By: Eric Ma <ericmjl@users.noreply.github.com> * Update README.md Co-Authored-By: Eric Ma <ericmjl@users.noreply.github.com> * Update README.md Co-Authored-By: Eric Ma <ericmjl@users.noreply.github.com> * Update README.md Co-Authored-By: Eric Ma <ericmjl@users.noreply.github.com> * add line break * update evoutuning docstring * Update README.md Co-authored-by: Eric Ma <ericmjl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The passing of params in evotuning was handled inconsistently.
This PR changes this, such that
paramsnow always expects the full tupleof weights: (mlstm1900, (), Dense, ()).
Weight dumping got adjusted accordingly, and there is a new convenience function
load_params, that by defaults loads all weights from the paper, and can also load previously dumped weights when supplied a folder path.