feat: Add vite_picture_tag for Rails 7.1 #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbrictson
force-pushed
the
features/vite_picture_tag
branch
from
62e7691
to
fa4b1ba
Compare
mattbrictson
commented
Oct 5, 2023
| actioncable (6.1.3.1) | ||
| actionpack (= 6.1.3.1) | ||
| activesupport (= 6.1.3.1) | ||
| actioncable (7.1.0) |
There was a problem hiding this comment.
🗒️ I updated the lock file to be able to test against Rails 7.1.0. Let me know if I should split this into a separate commit or PR.
| @@ -79,6 +79,17 @@ def vite_image_tag(name, **options) | |||
| image_tag(vite_asset_path(name), options) | |||
| end | |||
|
|
|||
| if defined?(Rails) && Rails.gem_version >= Gem::Version.new('7.1.0') | |||
There was a problem hiding this comment.
🤔 I had to add the defined? check to work around certain test failures. I assume that Rails will be defined when this file is loaded in a real app. Is there a better way to do this?
There was a problem hiding this comment.
That approach would have worked, but changed my mind as I'd like to provide more information in case users see it in the docs and try to use it in an older version of Rails.
Rails 7.1 introduced a `picture_tag` helper.[^1] This commit adds a corresponding `vite_picture_tag` helper that handles resolving assets via Vite, but otherwise behaves the same as `picture_tag`. It is only exposed for Rails >= 7.1.0. [^1]: rails/rails#48100
mattbrictson
force-pushed
the
features/vite_picture_tag
branch
from
fa4b1ba
to
a5827d4
Compare
… an older version of Rails
|
Nice addition, thanks Matt! Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
This commit adds a
vite_picture_taghelper that handles resolving assets via Vite, but otherwise behaves the same as the Rails built-inpicture_tag. It is only exposed for Rails >= 7.1.0. Fixes #386Background 📜
Rails 7.1 introduced a
picture_taghelper.1The Fix 🔨
Added
vite_picture_tagtoViteRails::TagHelperswith a corresponding test.Footnotes
https://github.com/rails/rails/pull/48100 ↩