Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign in ui is done #117

Merged
merged 6 commits into from
Jun 20, 2023
Merged

Sign in ui is done #117

merged 6 commits into from
Jun 20, 2023

Conversation

Joldubaev
Copy link
Collaborator

@Joldubaev Joldubaev commented Jun 17, 2023

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@Joldubaev Joldubaev added A0-ux PR changes the UX B0-low Does not elevate a release containing this beyond "low priority" C0-breaksnothing PR does not introduce any breaking changes labels Jun 17, 2023
Copy link
Owner

@Eldar2021 Eldar2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sonun chong rahmat sizge! Kee bir gana sunushtarym bar :)

app/lib/modules/login/view/login_view.dart Outdated Show resolved Hide resolved
app/lib/l10n/arb/app_tr.arb Outdated Show resolved Hide resolved
app/lib/l10n/arb/app_en.arb Outdated Show resolved Hide resolved
app/lib/modules/login/view/sign_in_view.dart Outdated Show resolved Hide resolved
app/pubspec.yaml Outdated Show resolved Hide resolved
Copy link
Owner

@Eldar2021 Eldar2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sabyrynyz uchun rahmat :) Sonun UI kelip jatkanyna ayabai kubanychtamyn. Az kaldy 👏

app/lib/constants/api/api_const.dart Show resolved Hide resolved
app/lib/l10n/arb/app_en.arb Show resolved Hide resolved
app/pubspec.yaml Outdated Show resolved Hide resolved
app/lib/modules/login/view/login_view.dart Outdated Show resolved Hide resolved
app/lib/modules/login/view/sign_in_view.dart Outdated Show resolved Hide resolved
@Eldar2021 Eldar2021 self-requested a review June 20, 2023 05:07
Copy link
Owner

@Eldar2021 Eldar2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally we are ready to merge this thanks a lot.

Comment on lines +15 to +18

errors:
todo: false
fixme: false
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 🤙

Comment on lines +24 to +25

// TODO(eldiiar): Replace the privacy policy URL with the actual [URL] of your privacy policy page.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice TODO 👍

Comment on lines +27 to +30
// You can enable it to see the SignIn page
// floatingActionButton: FloatingActionButton(
// onPressed: () => Navigator.pushNamed(context, AppRouter.signIn),
// ),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tam istediğim gibi teşekkürler :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bu dosyayı henüz test etmedim, ama temiz ve iyi görünüyor. O yüzden onaylıyorum. Elinize sağlık abi.

@Eldar2021 Eldar2021 merged commit 9b7de46 into main Jun 20, 2023
8 checks passed
@Eldar2021 Eldar2021 deleted the kl/sign-in-ui branch June 20, 2023 05:12
@Eldar2021 Eldar2021 mentioned this pull request Jun 20, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-ux PR changes the UX B0-low Does not elevate a release containing this beyond "low priority" C0-breaksnothing PR does not introduce any breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants