chore: remove lock files #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The yarn.lock and package-lock.json files are out of sync. This means depending on the tool used by the consumer a different set of dependencies will be installed. The lock files also result in the template pinning to a specific version of @elder/elderjs. Currently this is two minor releases behind the latest version. Is that a deliberate decision? It seems that rather than requiring manual updates to this template repo we should defer to the package manager to install the latest version specified by the package.json semver declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The yarn.lock and package-lock.json files are out of sync. This means depending on the tool used by the consumer a different set of dependencies will be installed.
The lock files also result in the template pinning to a specific version of @elder/elderjs. Currently this is two minor releases behind the latest version. Is that a deliberate decision? It seems that rather than requiring manual updates to this template repo we should defer to the package manager to install the latest version specified by the package.json semver declaration.