Moved to the CiphertextBallot and removed the deprecated one #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the order of the number of guardians and quorum for creating a new key ceremony
| @@ -40,7 +40,7 @@ public async Task CreateKeyCeremony() | |||
| return; | |||
| } | |||
|
|
|||
| var keyCeremony = new KeyCeremonyRecord(KeyCeremonyName, Quorum, NumberOfGuardians, this.UserName!); | |||
| var keyCeremony = new KeyCeremonyRecord(KeyCeremonyName, NumberOfGuardians, Quorum, this.UserName!); | |||
There was a problem hiding this comment.
just since we have had this issue in the past:
Suggested change
| var keyCeremony = new KeyCeremonyRecord(KeyCeremonyName, NumberOfGuardians, Quorum, this.UserName!); | |
| var keyCeremony = new KeyCeremonyRecord(name: KeyCeremonyName, | |
| numberOfGuardians: NumberOfGuardians, | |
| quorum: Quorum, | |
| admin: this.UserName!); |
john-s-morgan
approved these changes
May 5, 2023
john-s-morgan
pushed a commit
that referenced
this pull request
May 8, 2023
Fixed the order of the number of guardians and quorum for creating a new key ceremony
john-s-morgan
added a commit
that referenced
this pull request
May 8, 2023
* make Drive and ZipService use a consistent interface * Rename file to match class name * Add constants for filenames * Allow for multiple writes * update constants and IStorageService * implicit conversion for records to string * export encryption * Storage extract * Update Election * Bump actions/setup-node from 2 to 3 (#226) * Moved to the CiphertextBallot and removed the deprecated one (#228) Fixed the order of the number of guardians and quorum for creating a new key ceremony * remove uneeded files * export election package * resolve Linter issues * Cleanup * UtcNow not now * Unneeded using * Linter updates * constructor update * mark step 1 complete * AddBallots Button enabling * set DateTime on export * Mark election as exported * naming --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Steve Maier <82616727+SteveMaier-IRT@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the order of the number of guardians and quorum for creating a new key ceremony
Issue
Fixes #227
Description
Reorders the fields for creating a key ceremony.
Testing