Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved to the CiphertextBallot and removed the deprecated one #228

Merged
merged 1 commit into from
May 5, 2023
Merged

Moved to the CiphertextBallot and removed the deprecated one #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/electionguard-ui/ElectionGuard.UI/ViewModels/BallotUploadViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ private async Task Upload()
{
var filename = Path.GetFileName(currentBallot);
var ballotData = File.ReadAllText(currentBallot);
SubmittedBallot ballot = new(ballotData);
CiphertextBallot ballot = new(ballotData);

if (ballot.ManifestHash != _manifestHash)
{
Expand Down
4 changes: 2 additions & 2 deletions src/electionguard-ui/ElectionGuard.UI/ViewModels/CreateKeyCeremonyAdminViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using CommunityToolkit.Mvvm.Input;
using CommunityToolkit.Mvvm.Input;
using ElectionGuard.UI.Lib.Models;

namespace ElectionGuard.UI.ViewModels;
Expand Down Expand Up @@ -40,7 +40,7 @@ public async Task CreateKeyCeremony()
return;
}

var keyCeremony = new KeyCeremonyRecord(KeyCeremonyName, Quorum, NumberOfGuardians, this.UserName!);
var keyCeremony = new KeyCeremonyRecord(KeyCeremonyName, NumberOfGuardians, Quorum, this.UserName!);
var ret = await _keyCeremonyService.SaveAsync(keyCeremony);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just since we have had this issue in the past:

Suggested change
var keyCeremony = new KeyCeremonyRecord(KeyCeremonyName, NumberOfGuardians, Quorum, this.UserName!);
var keyCeremony = new KeyCeremonyRecord(name: KeyCeremonyName,
numberOfGuardians: NumberOfGuardians,
quorum: Quorum,
admin: this.UserName!);

var keyCeremonyId = ret.KeyCeremonyId!;
await NavigationService.GoToPage(typeof(ViewKeyCeremonyViewModel), new Dictionary<string, object>
Expand Down
Loading