Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1028] Runtime switch of lightwalletd servers #1044

Conversation

LukasKorba
Copy link
Collaborator

Closes #1028

  • error handling done
  • localized all new texts
  • custom server resolved with all possible parsing states
  • persistency of selected server done

This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.

Author

  • Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
  • Does the code abide by the Coding Guidelines?
  • Automated tests: Did you add appropriate automated tests for any code changes?
  • Code coverage: Did you check the code coverage report for the automated tests? While we are not looking for perfect coverage, the tool can point out potential cases that have been missed.
  • Documentation: Did you update Docs as appropiate? (E.g README.md, etc.)
  • Run the app: Did you run the app and try the changes?
  • Did you provide Screenshots of what the App looks like before and after your changes as part of the description of this PR? (only applicable to UI Changes)
  • Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

  • Checklist review: Did you go through the code with the Code Review Guidelines checklist?
  • Ad hoc review: Did you perform an ad hoc review? In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
  • Automated tests: Did you review the automated tests?
  • Manual tests: Did you review the manual tests?You will find manual testing guidelines under our manual testing section
  • How is Code Coverage affected by this PR? We encourage you to compare coverage before and after your changes and when possible, leave it in a better place. Learn More...
  • Documentation: Did you review Docs, README.md, LICENSE.md, and Architecture.md as appropriate?
  • Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data.

@LukasKorba LukasKorba marked this pull request as draft February 10, 2024 08:03
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this pull request Feb 10, 2024
- prototype of the solution implemented

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers

- error handling done
- localized all new texts
- custom server resolved with all possible parsing states
- persistency of selected server done

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044)

- changelog update
@LukasKorba LukasKorba force-pushed the 1028-Runtime-switch-of-lightwalletd-servers branch from 72eae15 to 76a5e9d Compare February 10, 2024 08:06
@LukasKorba LukasKorba added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 12, 2024
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this pull request Feb 12, 2024
- prototype of the solution implemented

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers

- error handling done
- localized all new texts
- custom server resolved with all possible parsing states
- persistency of selected server done

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044)

- changelog update

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044)

- Unfortunately the compiler has a bug so Circular reference error is not possible to solve, Apple fixed reported issue from October 2023 last week so we should expect fix in Xcode 15.3, beta is released but still no fix. Until that moment I moved placeholders to the view and will move it back to the stores once the issue is resolved
@LukasKorba LukasKorba force-pushed the 1028-Runtime-switch-of-lightwalletd-servers branch from 76a5e9d to ab0fae3 Compare February 12, 2024 12:01
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this pull request Feb 12, 2024
- prototype of the solution implemented

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers

- error handling done
- localized all new texts
- custom server resolved with all possible parsing states
- persistency of selected server done

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044)

- changelog update

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044)

- Unfortunately the compiler has a bug so Circular reference error is not possible to solve, Apple fixed reported issue from October 2023 last week so we should expect fix in Xcode 15.3, beta is released but still no fix. Until that moment I moved placeholders to the view and will move it back to the stores once the issue is resolved
@LukasKorba LukasKorba force-pushed the 1028-Runtime-switch-of-lightwalletd-servers branch from ab0fae3 to d28ec5e Compare February 12, 2024 12:12
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this pull request Feb 13, 2024
- prototype of the solution implemented

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers

- error handling done
- localized all new texts
- custom server resolved with all possible parsing states
- persistency of selected server done

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044)

- changelog update

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044)

- Unfortunately the compiler has a bug so Circular reference error is not possible to solve, Apple fixed reported issue from October 2023 last week so we should expect fix in Xcode 15.3, beta is released but still no fix. Until that moment I moved placeholders to the view and will move it back to the stores once the issue is resolved

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044)

- adoption of SDK 2.0.10
@LukasKorba LukasKorba force-pushed the 1028-Runtime-switch-of-lightwalletd-servers branch from d28ec5e to 0faa8d1 Compare February 13, 2024 07:53
@LukasKorba LukasKorba marked this pull request as ready for review February 13, 2024 07:56
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this pull request Feb 13, 2024
- prototype of the solution implemented

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers

- error handling done
- localized all new texts
- custom server resolved with all possible parsing states
- persistency of selected server done

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044)

- changelog update

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044)

- Unfortunately the compiler has a bug so Circular reference error is not possible to solve, Apple fixed reported issue from October 2023 last week so we should expect fix in Xcode 15.3, beta is released but still no fix. Until that moment I moved placeholders to the view and will move it back to the stores once the issue is resolved
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 0faa8d1 with comments, and the disclaimer that I Am Not A Swift Or iOS Developer.

@str4d str4d mentioned this pull request Feb 14, 2024
15 tasks
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this pull request Feb 14, 2024
- prototype of the solution implemented

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers

- error handling done
- localized all new texts
- custom server resolved with all possible parsing states
- persistency of selected server done

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044)

- changelog update

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044)

- Unfortunately the compiler has a bug so Circular reference error is not possible to solve, Apple fixed reported issue from October 2023 last week so we should expect fix in Xcode 15.3, beta is released but still no fix. Until that moment I moved placeholders to the view and will move it back to the stores once the issue is resolved

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044)

- adoption of SDK 2.0.10

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044)

- comments addressed
@LukasKorba LukasKorba force-pushed the 1028-Runtime-switch-of-lightwalletd-servers branch from 551ce82 to ec6e082 Compare February 14, 2024 10:10
@LukasKorba LukasKorba merged commit 924e318 into Electric-Coin-Company:main Feb 14, 2024
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this pull request Feb 14, 2024
- prototype of the solution implemented

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers

- error handling done
- localized all new texts
- custom server resolved with all possible parsing states
- persistency of selected server done

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044)

- changelog update

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044)

- Unfortunately the compiler has a bug so Circular reference error is not possible to solve, Apple fixed reported issue from October 2023 last week so we should expect fix in Xcode 15.3, beta is released but still no fix. Until that moment I moved placeholders to the view and will move it back to the stores once the issue is resolved

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044)

- adoption of SDK 2.0.10
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this pull request Feb 14, 2024
- prototype of the solution implemented

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers

- error handling done
- localized all new texts
- custom server resolved with all possible parsing states
- persistency of selected server done

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044)

- changelog update

[Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044)

- Unfortunately the compiler has a bug so Circular reference error is not possible to solve, Apple fixed reported issue from October 2023 last week so we should expect fix in Xcode 15.3, beta is released but still no fix. Until that moment I moved placeholders to the view and will move it back to the stores once the issue is resolved
@true-jared true-jared removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 14, 2024
@LukasKorba LukasKorba deleted the 1028-Runtime-switch-of-lightwalletd-servers branch April 4, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime switch of lightwalletd servers
4 participants