-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1032] Advanced settings #1047
Merged
LukasKorba
merged 3 commits into
Electric-Coin-Company:main
from
LukasKorba:1032-Advanced-settings
Feb 14, 2024
Merged
[#1032] Advanced settings #1047
LukasKorba
merged 3 commits into
Electric-Coin-Company:main
from
LukasKorba:1032-Advanced-settings
Feb 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasKorba
force-pushed
the
1032-Advanced-settings
branch
from
February 12, 2024 12:13
47b0cdc
to
6199229
Compare
LukasKorba
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Feb 12, 2024
LukasKorba
force-pushed
the
1032-Advanced-settings
branch
from
February 13, 2024 09:29
6199229
to
65d8ac5
Compare
LukasKorba
added a commit
to LukasKorba/secant-ios-wallet
that referenced
this pull request
Feb 13, 2024
- all buttons moved to appropriate positions and screens - business logic rewired - all new texts localized - changelog updated [Electric-Coin-Company#1032] Advanced settings - unit tests fixed [Electric-Coin-Company#1032] Advanced settings (Electric-Coin-Company#1047) - separate reducer for advanced settings
LukasKorba
force-pushed
the
1032-Advanced-settings
branch
from
February 13, 2024 11:03
65d8ac5
to
0cf120b
Compare
str4d
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- prototype of the solution implemented [Electric-Coin-Company#1028] Runtime switch of lightwalletd servers - error handling done - localized all new texts - custom server resolved with all possible parsing states - persistency of selected server done [Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044) - changelog update [Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044) - Unfortunately the compiler has a bug so Circular reference error is not possible to solve, Apple fixed reported issue from October 2023 last week so we should expect fix in Xcode 15.3, beta is released but still no fix. Until that moment I moved placeholders to the view and will move it back to the stores once the issue is resolved [Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044) - adoption of SDK 2.0.10
- prototype of the solution implemented [Electric-Coin-Company#1028] Runtime switch of lightwalletd servers - error handling done - localized all new texts - custom server resolved with all possible parsing states - persistency of selected server done [Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044) - changelog update [Electric-Coin-Company#1028] Runtime switch of lightwalletd servers (Electric-Coin-Company#1044) - Unfortunately the compiler has a bug so Circular reference error is not possible to solve, Apple fixed reported issue from October 2023 last week so we should expect fix in Xcode 15.3, beta is released but still no fix. Until that moment I moved placeholders to the view and will move it back to the stores once the issue is resolved
- all buttons moved to appropriate positions and screens - business logic rewired - all new texts localized - changelog updated [Electric-Coin-Company#1032] Advanced settings - unit tests fixed [Electric-Coin-Company#1032] Advanced settings (Electric-Coin-Company#1047) - separate reducer for advanced settings
LukasKorba
force-pushed
the
1032-Advanced-settings
branch
from
February 14, 2024 10:12
0cf120b
to
8498cff
Compare
true-jared
removed
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1032
Closes #1033
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author
Reviewer