Skip to content

Commit

Permalink
Requirements: Restring PyQt5 version to >=5.12.3 and < 5.15.3
Browse files Browse the repository at this point in the history
PyQt5 5.15.3 no longer ships binaries due to Qt's commercial license
shenanigans. This means if you install PyQt5 5.15.3, it just doesn't
work since the binaries are missing.  PyQt5 5.15.2 does not have this
problem, so we are stuck on 5.15.2 max version for now.
  • Loading branch information
cculianu committed Mar 5, 2021
1 parent 977b23c commit 6a5d606
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion contrib/requirements/requirements-binaries.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
PyQt5>=5.12.3
PyQt5<5.15.3,>=5.12.3
pycryptodomex
psutil

Expand Down
7 changes: 5 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
with open('contrib/requirements/requirements-hw.txt') as f:
requirements_hw = f.read().splitlines()

with open('contrib/requirements/requirements-binaries.txt') as f:
requirements_binaries = f.read().splitlines()

version = imp.load_source('version', 'electroncash/version.py')

if sys.version_info[:3] < (3, 6):
Expand Down Expand Up @@ -145,8 +148,8 @@ def run(self):
install_requires=requirements,
extras_require={
'hardware': requirements_hw,
'gui': ['pyqt5'],
'all': requirements_hw + ['pyqt5']
'gui': requirements_binaries,
'all': requirements_hw + requirements_binaries
},
packages=[
'electroncash',
Expand Down

0 comments on commit 6a5d606

Please sign in to comment.