Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS app does not handle network errors gracefully #849

Open
mhsmith opened this issue Sep 5, 2018 · 5 comments
Open

iOS app does not handle network errors gracefully #849

mhsmith opened this issue Sep 5, 2018 · 5 comments
Assignees
Labels
enhancement ios Bugs related to the iOS port (mostly lives in ios/)

Comments

@mhsmith
Copy link
Collaborator

mhsmith commented Sep 5, 2018

App version 3.3.1.

When trying to send a transaction in airplane mode, the app hangs on the "Broadcasting transaction" message for 30 seconds with no way to cancel. Then the following message appears:

error: module 'electroncash.util' has no attribute 'TimeoutException'

@cculianu cculianu self-assigned this Sep 5, 2018
@cculianu cculianu added bug ios Bugs related to the iOS port (mostly lives in ios/) labels Sep 5, 2018
@cculianu
Copy link
Collaborator

cculianu commented Sep 5, 2018

This is definitely not desirable behavior. I'm assigning it to myself and will look into improving it. Minimally that error shouldn't be there.

Thanks for reporting!

@mhsmith
Copy link
Collaborator Author

mhsmith commented Sep 5, 2018

The error message is an easy fix in network.py: on my Android branch I've just changed the line to:

raise Exception(_('Server did not answer'))

The file is also missing this import:

from .i18n import _

@cculianu
Copy link
Collaborator

cculianu commented Sep 5, 2018

D'oh!

Awesome.. thanks. I'll change it.

Also I want to see if I can add a cancel button.. cool thanks man!

cculianu added a commit that referenced this issue Sep 5, 2018
@cculianu
Copy link
Collaborator

cculianu commented Sep 5, 2018

Ok, I addressed the exception. Still need to see if I can make long-timeouts be less long (offer a cancel option).

@cculianu cculianu added enhancement and removed bug labels Sep 5, 2018
@mhsmith
Copy link
Collaborator Author

mhsmith commented Nov 28, 2018

Maybe related: #971.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ios Bugs related to the iOS port (mostly lives in ios/)
Projects
None yet
Development

No branches or pull requests

2 participants