Fixed code signing on OSX #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cculianu
added
macOS
cculianu
added
bug
and removed
Do Not Merge (Yet!)
|
It appears to work 100% as intended. I'm merging this. |
cculianu
added a commit
to simpleledger/Electron-Cash-SLP
that referenced
this pull request
Jan 16, 2019
Related: spesmilo#4994 OSX building wasn't code signing the bundled binaries that PyInstaller adds to the .zip embedded in the app executable. This could potentially cause issues in the future if MacOS versions in the future require fully signed apps.
cculianu
added a commit
to cculianu/Electron-Cash
that referenced
this pull request
Jan 16, 2019
This was pulled from Electron Cash Electron-Cash#1110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSX building wasn't code signing the bundled binaries that PyInstaller adds to the .zip embedded in the app executable.
This could potentially cause issues in the future if MacOS versions in the future require fully signed apps.
I'm still testing this change and/or refining it so please don't merge yet.