[fusion] Consolidating better, misc cleanup #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
markblundeberg
commented
Aug 21, 2020
markblundeberg
commented
- Make it so that consolidation is always actually shrinking wallet utxo set by each fusion having max of 3 outputs (thus minimum of 8 inputs). This way it always has an endpoint.
- Misc cleanups of locking in plugin.py
- Misc other cleanups in plugin.py
The lock wasn't being held everywhere it should, and anyway it doesn't need to be held so long in the plugins loop. This switches plugin.lock to be a finer grained lock, and reverses locking order (see create_fusion)... this likely needs more work in future.
- At most 3 outputs when we consolidate. - Therefore consolidation has an endpoint. - Try to slow down consolidations in late stages. (Maybe max_outputs should be made into a gui/config option for the power gamers?)
cculianu
reviewed
Aug 21, 2020
cculianu
reviewed
Aug 21, 2020
| # Locking order wallet.lock -> plugin.lock. | ||
| self.lock = threading.Lock() | ||
|
|
||
| self.fusions = weakref.WeakKeyDictionary() |
There was a problem hiding this comment.
so self.lock only guards self.fusions ? Or? Maybe we can have # Guarded by self.lock here for each attribute it does guard...
cculianu
reviewed
Aug 21, 2020
|
Well so I have no further old lady complaints. It seems to run for me. Did you test it and stuff? Is it ready for merge? |
|
I've been running it with 2 instances since yesterday, I've seen no issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.