Fix make_locale to be more pythonic #1972
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to build android app on Windows , but errors with make_locale becomes a show stopper.
Between line 24 and line 31 make_locale create a shell to execute a 'find' command to search all the files that needs to be translated. Although there is indeed a 'find' command on Windows, but it's totally different from the unix-like one.
This PR fix the problem by rewriting the relevant parts with pure os-agnostic python code.