Run history_list_filter hook on updated labels #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way an edited label can be filtered directly instead of during update of the entire history_list. This can be seen if someone has CashFusion running and the "Hide CashFusions" option enabled and proceeds to rename a label to start with "CashFusion ". Without this fix the transaction is not hidden until the wallet is restarted or the "Hide CashFusions" option is toggled off and on.
cculianu
reviewed
Sep 8, 2020
This is to avoid a costly wallet.get_history() call.
cculianu
reviewed
Sep 12, 2020
cculianu
reviewed
Sep 12, 2020
|
Ok, looks good man. Thanks for being responsive and for the change. Merging. |
cculianu
added a commit
that referenced
this pull request
Sep 12, 2020
This was the history list filter PR. This was included in release 4.1.1 but we forgot to mention it in RELEASE-NOTES since it made it in just before release.
EchterAgo
pushed a commit
to EchterAgo/Electron-Cash
that referenced
this pull request
Mar 9, 2021
* Run history_list_filter hook on updated labels This way an edited label can be filtered directly instead of during update of the entire history_list. This can be seen if someone has CashFusion running and the "Hide CashFusions" option enabled and proceeds to rename a label to start with "CashFusion ". Without this fix the transaction is not hidden until the wallet is restarted or the "Hide CashFusions" option is toggled off and on. * Create itemChanged callback for history_list * Send None as h_item This is to avoid a costly wallet.get_history() call. * Use item.text() instead of item.data()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way an edited label can be filtered directly instead of during
update of the entire history_list.
This can be seen if someone has CashFusion running and the "Hide
CashFusions" option enabled and proceeds to rename a label to start with
"CashFusion ".
Without this fix the transaction is not hidden until the
wallet is restarted or the "Hide CashFusions" option is toggled off and
on.