Added addtransaction arg to payto/paytomany #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
cculianu
reviewed
Sep 19, 2020
cculianu
reviewed
Sep 19, 2020
|
Ok so you tested it? It's working for you now after the 4 changes? |
|
Yes, now with more changes I even got 50 payto in a row! Works! :D |
|
Ok, merging. |
EchterAgo
pushed a commit
to EchterAgo/Electron-Cash
that referenced
this pull request
Mar 9, 2021
* Added addtransaction arg to payto/paytomany * Add to wallet history only if signed * Check for duplicates in add_tx_to_history * Fix add_tx_to_history duplicates check --- This PR is a backport of spesmilo#6532 It makes it possible to use payto/paytomany+broadcast commands in concurrent environments when turning addtransaction flag on by adding tx to local history before a full network round-trip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a backport of spesmilo#6532
It makes it possible to use payto/paytomany+broadcast commands in concurrent environments when turning addtransaction flag on by adding tx to local history before a full network round-trip.