Ledger: Fix warning about unverified inputs #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this with a Ledger Nano S. I tested P2SH multisig and P2PKH. |
|
Oh, I also tested multiple outputs in one transaction. |
|
I want to test this with HW1, so don't merge this yet. |
Starting in version 1.4.0 of the Ledger Bitcoin app, additional data needs to be sent for inputs to prevent the firmware warning about unverified inputs. See https://donjon.ledger.com/lsb/010/
EchterAgo
force-pushed
the
ledger_fix_unverified_inputs
branch
from
dcdb1d6
to
08683d9
Compare
|
Updated to work on HW1. Also removed misleading comment, the This is now tested with a Ledger Nano S and a Ledger HW1 with P2SH and P2PKH. |
|
Awesome.. looks good to me. Thanks for addressing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in version 1.4.0 of the Ledger Bitcoin app, additional data needs to be sent for inputs to prevent the firmware warning about unverified inputs. See https://donjon.ledger.com/lsb/010/