Ledger: Test firmware version for trusted input requirement #2008
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last change broke Ledger Nano S/X on firmware versions < 1.4.0. We now check the firmware version to see if we need to use trusted inputs or not. The behaviour with firmware version < 1.4.0 is the same as before.
|
Wait for James to test the change before merging. See simpleledger#136 |
|
@EchterAgo @jcramer Gotcha. Let me know here or in Slack if/when this is verified and when to merge. |
|
Tested on my Ledger Nano with firmware 1.3.13. Without this patch, I get errors and cannot sign. With it, I can sign and tx's are valid. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last change broke Ledger Nano S/X on firmware versions < 1.4.0.
We now check the firmware version to see if we need to use trusted inputs or not. The behaviour with firmware version < 1.4.0 is the same as before.