Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add git_describe_filtered helper #2160

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

EchterAgo
Copy link

This filters out the android-* and ios_* tags by default but can also be used to select specific tag prefixes.

@EchterAgo
Copy link
Author

@EchterAgo
Copy link
Author

This needs more work, the wine build ends up with -dirty suffix for some reason.

@EchterAgo EchterAgo changed the title Build: Add git_describe_filtered helper [WIP] Build: Add git_describe_filtered helper Feb 9, 2021
@EchterAgo
Copy link
Author

Working now:

https://ec.loping.net/4.2.3-114-gdccabfeef/

@EchterAgo EchterAgo changed the title [WIP] Build: Add git_describe_filtered helper Build: Add git_describe_filtered helper Feb 9, 2021
ios/make_ios_project.sh Outdated Show resolved Hide resolved
@cculianu cculianu added code quality Improvements to code, refactoring, etc packaging Issues related to building/packaging and not the app itself. labels Feb 9, 2021
This filters out the `android-*` and `ios_*` tags by default but can
also be used to select specific tag prefixes.
@cculianu
Copy link
Collaborator

cculianu commented Feb 9, 2021

Looks great, thanks man.

@cculianu cculianu merged commit 7828512 into Electron-Cash:master Feb 9, 2021
@EchterAgo EchterAgo deleted the git_describe_filter branch February 9, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improvements to code, refactoring, etc packaging Issues related to building/packaging and not the app itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants