Remove if-False code

[gasull]

This code was disabled over a year and a half ago and isn't needed anymore.

Related issue: #2213

---

This change is 

[EchterAgo]

We changed this when we switched to Freetype on Windows, which made the ⓢ render good. Due to other issues we later made this optional and default to off, but never switched back to (S). This should probably be conditional so that it uses (S) only if the platform is Windows and Freetype is disabled.

[EchterAgo]

FYI, this is how the ⓢ looks on Windows with native font rendering:

Really bad, and that is on a High-DPI 4K screen. Somehow Windows does not do Cleartype for that character at all.

[cculianu]

Yeah we probably want to both detect freetype and window here somehow -- how would one detect freetype? Would that be a detection that can be made once at "module import time"?

[EchterAgo]

I would just use the windows_qt_use_freetype setting and test for sys.platform in ('win32', 'cygwin')

[gasull]

I would just use the windows_qt_use_freetype setting and test for sys.platform in ('win32', 'cygwin')

So if we're on Windows and FreeType is detected, we should still use SCHNORR_SIGIL = "ⓢ". Correct?

And if we're on Windows but FreeType isn't detected, should use SCHNORR_SIGIL = "(S)". Am I right?

[EchterAgo]

So if we're on Windows and FreeType is detected, we should still use SCHNORR_SIGIL = "ⓢ". Correct?

Yes

And if we're on Windows but FreeType isn't detected, should use SCHNORR_SIGIL = "(S)". Am I right?

Yes

[gasull]

I'm closing this PR in favor of a new one: #2236