Build: Verify the Python checksums #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, whoever has a copy of the Python release signing key is a trusted third party. This commit changes this so that in addition to checking the signature of the installers, the checksums are also verified. This is motivated by the Python 3.8.9 release (2021-04-02) being replaced with a different version (2021-04-06) that didn't match the PGP signature.
|
The full build is still running, but I tested the checksum part, good checksums pass, bad checksums fail the build. |
|
Yes, this is a good idea. |
|
Decent change but the true fix to remove trust would be to build python from source in the script :/ |
Yea, right. I'm not sure if the Windows Python Installer is built reproducible. Now that https://bugs.winehq.org/show_bug.cgi?id=49897 is fixed in Wine 6.6, it should be possible to get the Visual C++ Build Tools working more easily in Wine, so maybe we can build Python and extensions soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, whoever has a copy of the Python release signing key is a trusted third party. This commit changes this so that in addition to checking the signature of the installers, the checksums are also verified.
This is motivated by the Python 3.8.9 release (2021-04-02) being replaced with a different version (2021-04-06) that didn't match the PGP signature.