Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Update dnspython to version 2.2.0 #2530

Merged
merged 1 commit into from Jan 13, 2023

Conversation

EchterAgo
Copy link

dnspython 2.1.0 introduced a dependency on poetry which caused a lot of other dependencies to be installed and made build slow.

dnspython 2.2.0 only requires poetry-core, which is faster to install.

rthalley/dnspython@da279de

backport of spesmilo@d9b55ae

thanks @PiRK for pointing me in the right direction

`dnspython` 2.1.0 introduced a dependency on `poetry` which caused a lot
of other dependencies to be installed and made build slow.

`dnspython` 2.2.0 only requires `poetry-core`, which is faster to install.

rthalley/dnspython@da279de

backport of spesmilo@d9b55ae
@EchterAgo
Copy link
Author

For me this reduces the AppImage build time on a 32-core system from 2 hours to 11 minutes.

@cculianu
Copy link
Collaborator

Thanks for this!

@cculianu cculianu merged commit 46328bf into Electron-Cash:master Jan 13, 2023
@EchterAgo EchterAgo deleted the dnspython_update branch January 13, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants