Format display numbers #17
Conversation
# Conflicts: # src/fragmentarium/ui/display/__snapshots__/Display.test.tsx.snap
# Conflicts: # src/fragmentarium/ui/display/__snapshots__/Display.test.tsx.snap
# Conflicts: # src/fragmentarium/ui/display/Display.sass
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| const rulingsToNumber: ReadonlyMap<string, number> = new Map([ | ||
| ['SINGLE', 1], | ||
| ['DOUBLE', 2], | ||
| ['TRIPLE', 3] | ||
| ]) | ||
|
|
|
This pull request introduces 1 alert when merging 3b815d9 into 01821ac - view on LGTM.com new alerts:
|
| ) | ||
| } | ||
|
|
||
| function isCloseEnclosure(token: Token): boolean { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| return isEnclosure(token) && ['CENTER', 'RIGHT'].includes(token.side) | ||
| } | ||
|
|
||
| function isOpenEnclosure(token: Token): boolean { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| content | ||
| }: { | ||
| content: ReadonlyArray<Token> | ||
| }): any { |
There was a problem hiding this comment.
any type should be avoided. Use a correct return type for function component.
| ) | ||
| } | ||
|
|
||
| function isCloseEnclosure(token: Token): boolean { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| return isEnclosure(token) && ['CENTER', 'RIGHT'].includes(token.side) | ||
| } | ||
|
|
||
| function isOpenEnclosure(token: Token): boolean { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit d554f06 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 89.4% (0.1% change). View more on Code Climate. |
|
This pull request introduces 2 alerts when merging 57dbb01 into 01821ac - view on LGTM.com new alerts:
|
|
Moved to #20 |
No description provided.