Test otaa mode #19
Merged
Test otaa mode #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
already tested examples .
sabas1080
requested changes
Jun 9, 2019
There was a problem hiding this comment.
Hi @ivan28823 nice work, please modify the travis file for new examples please
|
hey ivan really nice work i will test all the functions this week, promise! Thanks for the hard work |
wero1414
requested changes
Jun 11, 2019
|
I test the changes with my examples and everything went ok, but when i tried to get your examples working i could not compile them i review the errors |
sabas1080
approved these changes
Jun 11, 2019
sabas1080
requested changes
Jun 11, 2019
wero1414
approved these changes
Jun 11, 2019
|
Perfect, now everything compile, can you add to travis to merge and release another version? |
Closed
sabas1080
approved these changes
Jun 11, 2019
|
Nice, all ok, I make merge, thanks @ivan28823! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add otaa join procedure in lora.join(), remove commands and add examples