Test: Formatting Check Always Finishes Successfully on Second Invocation

[sanssecours]

Steps to Reproduce the Problem

• Add some incorrectly formatted C or C++ code to the repository

Expected Result

Either Cirrus or Travis should report the incorrectly formatted code. The build jobs that test formatting should finish unsuccessfully.

Actual Result

All build jobs finish successfully.

Additional Information

The script testscr_check_formatting fails in the CI builds as expected. However, since we use ctest $ARGS --rerun-failed:

libelektra/scripts/dev/run_all.in

Line 17 in 8d9dba1

ctest $ARGS || ctest $ARGS --rerun-failed

the test testscr_check_formatting is executed again. This time the test does not fail, since the source was modified:

libelektra/tests/shell/check_formatting.sh

Lines 14 to 17 in 8d9dba1

	if ! git diff --quiet; then
	printf >&2 'Source is already modified, aborting test!\n\n'
	exit 0
	fi

.

Possible Fix

One option to solve this problem would be to stash the current changes at the end of the check_formatting.sh. I do not know if doing that has other unintended consequences though.

[markus2330]

Thank you so much for this detailed issue. I think this is a good first issue?