Invoke error key #1801
Merged
Invoke error key #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markus2330
reviewed
Jan 30, 2018
| } | ||
| else | ||
| { | ||
| keyIncRef (errorKey); |
There was a problem hiding this comment.
Is this needed? Who decrements the reference?
There was a problem hiding this comment.
In every case keyDel (errorKey) is called. If the user has passed a key, the reference is increased beforehand so the user's passed key won't get deleted at this point. If the user passed 0, a key was created inside the invoke library and it will be deleted.
|
any objections? otherwise ready to merge |
|
Thank you, great job! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds the possibility for the invoke library to report errors when trying to open/close a plugin as discussed in #1795 .
Checklist
@markus2330 As C doesn't support overloaded functions, i've adjusted the original interface now as its not a part of the core elektra library as far as i've understood because i think the function names fit pretty well. I've also adapted those few plugins using it already, but for those i am passing simply 0 as the error key so invoke will take care about the error key creation itself, which basically is the old behavior to avoid possibly breaking anything in plugins i do not maintain. For my own plugins i've incorporated the new error key already (and even had to do a small pluginprocess library adjustment.