Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown Link Converter: Change Location Style #2445

Merged
merged 2 commits into from
Mar 1, 2019

Conversation

sanssecours
Copy link
Member

No description provided.

@markus2330
Copy link
Contributor

The previous style was created for some other editor. But I am okay with this change if it works better for you.

@sanssecours
Copy link
Member Author

The previous style was created for some other editor.

Interesting. Do you remember the name of the editor? The location style

file:line:column

should be pretty much the standard format. For example, it is also the default style for error messages, if you compile some files with clang or gcc.

@markus2330
Copy link
Contributor

markus2330 commented Feb 28, 2019

For example, it is also the default style for error messages, if you compile some files with clang or gcc.

Yes, this was the reason. Isn't it better to keep it, then?

@sanssecours
Copy link
Member Author

sanssecours commented Feb 28, 2019

Yes, this was the reason. Isn't it better to keep it, then?

Your version of clang and gcc uses

file|line col column|

as default error style? At least

seem to use

file:line:column

by default, according to the output of various build jobs.

filename|line col 0|
```

to show the location data for broken links. This has the advantage, that certain tools such as [TextMate](https://macromates.com) are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed: please write here that this is a default format for gcc, clang, ...

While the location style:

    filename|line col 0|

is perfectly readable by a human, most applications prefer something
like

    filename:line:0

. For example, in TextMate the second variant does produce clickable
links, while the first style does not.
@@ -9,7 +9,7 @@ should be hard to use it in a wrong way. This tutorial gives an introduction for
using the high-level API.

The API supports all CORBA Basic Data Types, except for `wchar`, as well as the `string` type
(see also [Data Types](../high-level-api#data-types) below).
(see also [Data Types](#data-types) below).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work on the homepage (also not the previous version)

https://www.libelektra.org/tutorials/high-level-api

@markus2330 markus2330 merged commit ded67df into ElektraInitiative:master Mar 1, 2019
@markus2330
Copy link
Contributor

Thank you! Can you open an issue or PR for the broken links please?

@sanssecours sanssecours deleted the 🔗 branch March 1, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants