-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy website #3290
Deploy website #3290
Conversation
Thank you for working on this! Note that the deployment is only done on a7. To deploy on www.libelektra.org we would need to copy the artifacts there. |
I noticed that. I'd still like to somewhat automate it. I was able to build it locally after all by checking the website Docker image. You really need to do the Edit: so basically I don't know why/when it stopped working. 😄 |
@markus2330 side note: www.libelektra on port 80 and 443 serve two completely different directories. I'll probably clean that up too if there was no reason to do that. To me this just complicates deployment. |
It should not be too difficult to copy the artifacts to the right place (except of the login but this should already be fixed as we already copy docu&coverage reports to the community node). Additionally, we could also deploy the docker container on a VM on our server. @Mistreated is currently trying to get a VM running (as build agent). We could create one more VM for our docker deployments. But actually this was @Mistreated's task.
Good to know. I wonder why this got broken on my system (I definitely did it at some point). The error message could definitely be improved, though 😄 |
b0bb507
to
cfaf374
Compare
jenkins build libelektra please |
1 similar comment
jenkins build libelektra please |
@markus2330 did I understand it correctly that we will get rid of website-backend completely, since it has not been working for a while? When updating the images I noticed that using a newer gcc libasan requires privileged capabilities (ptrace) for the container during Do we:
|
If think disabling AddressSanitizer ( |
Thank you, I overlooked that option! I also thought it was not necessary, but @markus2330 suggested that this is for security reasons as it catches undefined behavior. The backend to my knowledge converts the configuration snippets (etc.), so it provides a rich attack surface. |
Yes, I would suggest to not waste too much time on that. I tried myself to get it working again but much more work is needed. Furthermore, it depends on several C++ libs which all are also outdated and would need upgrades. So best we simply remove the parts in the website related to the snippet sharing and avoid having this backend. The WebUI is much more fun anyway. Better to have this running again.
Yes, I think this is the best option. |
Basics
These points need to be fulfilled for every PR:
(added as entry in
doc/news/_preparation_next_release.md
whichcontains
_(my name)_
)Please always add something to the release notes.
(first line should have
module: short statement
syntax)close #X
, are in the commit messages.If you have any troubles fulfilling these criteria, please write
about the trouble as comment in the PR. We will help you.
But we cannot accept PRs that do not fulfill the basics.
Checklist
Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.
(not in the PR description)
Review
Reviewers will usually check the following:
Labels
If you are already Elektra developer:
say that everything is ready to be merged.