Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu: add popper-append-to-body for SubMenu #10515

Merged
merged 1 commit into from
Apr 2, 2018

Conversation

Leopoldthecoder
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

Resolves #10513

  • Make sure you follow Element's contributing guide (中文 | English | Español).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@Leopoldthecoder Leopoldthecoder merged commit c8ff3ad into ElemeFE:dev Apr 2, 2018
@@ -8,6 +8,18 @@ export declare class ElSubmenu extends ElementUIComponent {
/** Delay time before show a sub-menu */
showTimeout: number

/** Delay time before hide a sub-menu */
/** Delay time before showing a sub-menu */
showTimeout: number

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is duplicate, declaration.
caused module to throw error when building with webpack.
Can you please remove the duplicate declaration of type for - showTimeout form type file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants