tab: fix active bar bug (#14416) #14496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Tab active bar doesn't resize when tab label changes dynamically
|
Deploy preview for element ready! Built with commit 9c68319 |
|
@Leopoldthecoder, @ziyoung, @wacky6, @jikkai can anyone look at this? |
ziyoung
reviewed
Mar 25, 2019
|
@akki-jat update your pr. I will merge it soon. |
changes done as suggested in review
gukong
added a commit
to meetinco/element
that referenced
this pull request
May 14, 2019
This reverts commit 9736448
weisiren168
pushed a commit
to weisiren168/element
that referenced
this pull request
Jun 20, 2019
* tab: fix active bar bug (ElemeFE#14416) fix: Tab active bar doesn't resize when tab label changes dynamically * tab: fix active bar bug changes done as suggested in review
3 tasks
lzq4047
pushed a commit
to lzq4047/element
that referenced
this pull request
May 22, 2020
* tab: fix active bar bug (ElemeFE#14416) fix: Tab active bar doesn't resize when tab label changes dynamically * tab: fix active bar bug changes done as suggested in review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Tab active bar doesn't resize when tab label changes dynamically
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.