Image: fix Esc can never close the preview at the second time #1… #19027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for element ready! Built with commit efc5189 |
giligiliduang
changed the title
CarterLi
added a commit
to CarterLi/element
that referenced
this pull request
Mar 28, 2020
1. set preview `:initial-index` to `0` if src is not in previewSrcList and also fix preview example 2. fix ESC won't close preview for the second time ElemeFE#19027 ElemeFE#18906 3. fix undesired `overflow: scroll` style ElemeFE#18967 4. fix a race condition if src changes too frequently https://github.com/ElemeFE/element/pull/18837/files 5. add `close-on-click-modal` prop https://github.com/ElemeFE/element/pull/18947/files
CarterLi
added a commit
to CarterLi/element
that referenced
this pull request
Mar 30, 2020
1. set preview `:initial-index` to `0` if src is not in previewSrcList and also fix preview example 2. fix ESC won't close preview for the second time ElemeFE#19027 ElemeFE#18906 3. fix undesired `overflow: scroll` style ElemeFE#18967 4. fix a race condition if src changes too frequently https://github.com/ElemeFE/element/pull/18837/files 5. add `close-on-click-modal` prop https://github.com/ElemeFE/element/pull/18947/files
3 tasks
CarterLi
added a commit
to CarterLi/element
that referenced
this pull request
Mar 30, 2020
1. set preview `:initial-index` to `0` if src is not in previewSrcList ElemeFE#18871 and also fix preview example 2. fix ESC won't close preview for the second time ElemeFE#19027 ElemeFE#18906 3. fix undesired `overflow: scroll` style ElemeFE#18967 4. fix a race condition if src changes too frequently ElemeFE#18837 5. add `close-on-click-modal` prop ElemeFE#18947
ZJL8
pushed a commit
to EOITek/element
that referenced
this pull request
Mar 30, 2020
1. set preview `:initial-index` to `0` if src is not in previewSrcList ElemeFE#18871 and also fix preview example 2. fix ESC won't close preview for the second time ElemeFE#19027 ElemeFE#18906 3. fix undesired `overflow: scroll` style ElemeFE#18967 4. fix a race condition if src changes too frequently ElemeFE#18837 5. add `close-on-click-modal` prop ElemeFE#18947
3 tasks
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18983
hide方法里面调用了deviceSupportUninstall导致document的事件被卸载，所以第二次打开没法使用esc关闭预览