This repository has been archived by the owner on Sep 28, 2022. It is now read-only.
image: apply various fixes #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. set preview `:initial-index` to `0` if src is not in previewSrcList ElemeFE#18871 and also fix preview example 2. fix ESC won't close preview for the second time ElemeFE#19027 ElemeFE#18906 3. fix undesired `overflow: scroll` style ElemeFE#18967 4. fix a race condition if src changes too frequently ElemeFE#18837 5. add `close-on-click-modal` prop ElemeFE#18947
ZJL8
reviewed
Mar 30, 2020
| @@ -216,7 +202,7 @@ export default { | |||
| }, | |||
| handleImgError(e) { | |||
| this.loading = false; | |||
| e.target.alt = '加载失败'; | |||
| e.target.alt = this.t('el.image.error'); | |||
CarterLi
commented
Mar 30, 2020
| this.loading = true; | ||
| } | ||
| }); | ||
| } | ||
| }, | ||
| methods: { | ||
| hide() { | ||
| this.deviceSupportUninstall(); |
There was a problem hiding this comment.
这个方法在 destroyed 调用了，整个组件是用 v-if 管理的
见 https://github.com/EOITek/element/pull/18/files#diff-4070c65e02876a1516baf9e0f17ebc22R18
CarterLi
commented
Mar 30, 2020
| @@ -216,7 +202,7 @@ export default { | |||
| }, | |||
| handleImgError(e) { | |||
| this.loading = false; | |||
| e.target.alt = '加载失败'; | |||
| e.target.alt = this.t('el.image.error'); | |||
There was a problem hiding this comment.
this.t 是element做国际化使用的方法，会按照名字查找对应的翻译
ZJL8
reviewed
Mar 30, 2020
| await wait(1000); | ||
| expect($wrapper.style.display).to.equal('none'); | ||
| await wait(600); | ||
| expect(vm.$el.querySelector('.el-image-viewer__wrapper')).to.be.null; |
There was a problem hiding this comment.
to.be.null 就是 === null，这是单元测试的语法
CarterLi
commented
Mar 30, 2020
| await wait(1000); | ||
| expect($wrapper.style.display).to.equal('none'); | ||
| await wait(600); | ||
| expect(vm.$el.querySelector('.el-image-viewer__wrapper')).to.be.null; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:initial-indexto0if src is not in previewSrcListfix: The first list is displayed by default when there is no
srcin thepreviewSrcListElemeFE/element#18871and also fix preview example
如果
previewSrcList里没有当前显示的图片url，默认预览第一张图片（example里的情况）修复第二次打开预览界面后ESC无效bug
Image: fix Esc can never close the preview at the second time #1… ElemeFE/element#19027
[Image]: Fix page cannot scroll up and down when previewSrcList is empty ElemeFE/element#18906
overflow: scrollstyle修复点击没有预览功能的图片后body上加了
overflow: scroll的bugImage: don't show image-viewer when preview is false ElemeFE/element#18967
修复如果用户点击过快事件触发混乱的bug
Image: fix a race condition if src changes too frequently ElemeFE/element#18837
close-on-click-modalprop添加点击遮罩层关闭预览的功能
image: 增加 close-on-click-modal props 控制点击mask 关闭预览图的功能 ElemeFE/element#18947
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.