Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scss file compile error when using dart-sass #20022

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

roojay520
Copy link
Contributor

当使用 dart-sass 对项目的主题文件进行编译时, 双引号会导致编译失败

elementui-scss-error

@element-bot
Copy link
Member

Deploy preview for element ready!

Built with commit 243917a

https://deploy-preview-20022--element.netlify.app

Copy link

@boomyao boomyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's ok

@storskegg
Copy link

storskegg commented Aug 21, 2020

I was just about to submit a fix to this very same issue. the same error is thrown by the underlying "sass" package, at least with 1.26.x. (node-sass seems to be more syntactically lenient re: this issue.)

@FrankCheungDev
Copy link

I wonder why this commit is not deployed yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants